Skip to content

Commit

Permalink
feat: add template value for kratos metric path (#654)
Browse files Browse the repository at this point in the history
  • Loading branch information
fleblay authored Nov 28, 2023
1 parent 7fb19cd commit 831cdf2
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 1 deletion.
3 changes: 3 additions & 0 deletions hacks/values/kratos.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -331,3 +331,6 @@ test:
busybox:
repository: docker.io/library/busybox
tag: 1.36
service:
admin:
metricsPath: "/admin/metrics/different-prometheus-path"
2 changes: 1 addition & 1 deletion helm/charts/kratos/templates/service-admin.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ metadata:
{{- end }}
spec:
endpoints:
- path: /admin/metrics/prometheus
- path: {{ .Values.service.admin.metricsPath }}
port: {{ .Values.service.admin.name }}
scheme: {{ .Values.serviceMonitor.scheme }}
interval: {{ .Values.serviceMonitor.scrapeInterval }}
Expand Down
2 changes: 2 additions & 0 deletions helm/charts/kratos/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ service:
annotations: {}
# kubernetes.io/ingress.class: nginx
# kubernetes.io/tls-acme: "true"
# -- Path to the metrics endpoint
metricsPath: /admin/metrics/prometheus
public:
enabled: true
type: ClusterIP
Expand Down

0 comments on commit 831cdf2

Please sign in to comment.