Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: template configmaps #703

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Conversation

jagregory
Copy link
Contributor

The Kratos chart allows templating the config settings in the chart values via the Helm tpl function, but the other charts don't allow this. Templating is very helpful for if you need to provide values which are based on other values in your environment, e.g. if parts of URLs include the {{ .Release.Name }} as they do with many 3rd party charts.

This PR includes:

  • Keto: add tpl to the existing keto.configmap helper
  • Hydra: add tpl to the existing hydra.configmap helper
  • Oathkeeper: add a oathkeeper.configmap helper which behaves the same as the other charts

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Copy link
Collaborator

@Demonsthere Demonsthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As with the second PR, nothing against, just please update the hacks/values to include such an example in tests (mostly static validation, to ensure the output yaml is stil valid) :)

@jagregory
Copy link
Contributor Author

jagregory commented Sep 17, 2024 via email

Copy link
Collaborator

@Demonsthere Demonsthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Demonsthere Demonsthere merged commit e011f35 into ory:master Sep 27, 2024
17 checks passed
@jagregory jagregory deleted the hydra-template-config branch September 29, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants