Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: order the list of identity sessions by authenticated_at #3324

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Jun 19, 2023

Fixes ory/network#295
Fixes #3307 (comment)

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl requested a review from jonas-jonas June 19, 2023 10:08
@hperl hperl self-assigned this Jun 19, 2023
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #3324 (620c8b3) into master (7182eca) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 620c8b3 differs from pull request most recent head 5827a71. Consider uploading reports for the commit 5827a71 to get more accurate results

@@           Coverage Diff           @@
##           master    #3324   +/-   ##
=======================================
  Coverage   78.11%   78.12%           
=======================================
  Files         325      325           
  Lines       21081    21086    +5     
=======================================
+ Hits        16468    16473    +5     
  Misses       3384     3384           
  Partials     1229     1229           
Impacted Files Coverage Δ
identity/extension_recovery.go 96.66% <100.00%> (+0.23%) ⬆️
identity/extension_verify.go 97.67% <100.00%> (+0.11%) ⬆️
persistence/sql/persister_session.go 84.92% <100.00%> (+0.06%) ⬆️

@hperl hperl force-pushed the hperl/order-list-identity-sessions branch from 3f6ad14 to 0d9057c Compare June 19, 2023 10:52
aeneasr
aeneasr previously approved these changes Jun 19, 2023
@aeneasr aeneasr force-pushed the hperl/order-list-identity-sessions branch from 21d096d to 5827a71 Compare June 21, 2023 08:31
@aeneasr aeneasr merged commit 46f92ff into master Jun 21, 2023
@aeneasr aeneasr deleted the hperl/order-list-identity-sessions branch June 21, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants