fix: maintain jaeger trace b3 sampled state #726
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`AlwaysSample()` will include spans whose parents were not sampled, which is generally unwanted as it leads to leaf nodes without parents in the telemetry graph. This change updates the jaeger setup to use the [otel spec default] `ParentBased(AlwaysSample())` which fixes this issue. [otel spec default]: https://github.com/open-telemetry/opentelemetry-specification/blob/v1.25.0/specification/trace/sdk.md#built-in-samplers
ptescher
approved these changes
Sep 18, 2023
|
Implemented in #765 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AlwaysSample()will include spans whose parents were not sampled, which is generally unwanted as it leads to leaf nodes without parents in the telemetry graph. This change updates the jaeger setup to use the otel spec defaultParentBased(AlwaysSample())which fixes this issue.Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
Further comments
This parent-based behavior was used in this repo via the jaeger-client-go library before the switch to otel as that exporter always defers to parent span sampling decisions.