Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change conflict handling and add some features #16315

Merged
merged 7 commits into from
Mar 18, 2024

Conversation

@dzedro dzedro added notready WIP Work in progress labels Feb 3, 2023
@dzedro dzedro marked this pull request as draft February 3, 2023 15:49
@dzedro dzedro changed the title Conflict Change conflict handling for zypper 14+ version Feb 6, 2023
@dzedro dzedro force-pushed the update_conflict branch 8 times, most recently from f663399 to 65913aa Compare February 10, 2023 12:25
@dzedro dzedro force-pushed the update_conflict branch from 19dacdd to dae5807 Compare May 23, 2023 13:40
@dzedro dzedro force-pushed the update_conflict branch from 14c3037 to d8b4eb5 Compare June 6, 2023 08:46
@dzedro dzedro force-pushed the update_conflict branch 4 times, most recently from e2e51d1 to 2335e23 Compare November 16, 2023 18:03
@dzedro dzedro removed notready WIP Work in progress labels Feb 21, 2024
@dzedro dzedro changed the title Change conflict handling for zypper 14+ version Change conflict handling and add som features Feb 21, 2024
@dzedro dzedro marked this pull request as ready for review March 5, 2024 13:05
@dzedro dzedro added Ready Ready for review qe-core Tag used to filter PR's created by QE-Core's members or are assigned to them labels Mar 5, 2024
@rfan1
Copy link
Contributor

rfan1 commented Mar 7, 2024

Commit message has a typo: Change conflict handling and add som features -> Change conflict handling and add some features

@rfan1
Copy link
Contributor

rfan1 commented Mar 7, 2024

One more minor comment, can we add a setting like "CONFLICT_PACKAGES" to add more if any? anyway, it is not hard required.

@dzedro
Copy link
Contributor Author

dzedro commented Mar 7, 2024

One more minor comment, can we add a setting like "CONFLICT_PACKAGES" to add more if any? anyway, it is not hard required.

You mean like with UPDATE_ADD_CONFLICT ?

@rfan1
Copy link
Contributor

rfan1 commented Mar 7, 2024

One more minor comment, can we add a setting like "CONFLICT_PACKAGES" to add more if any? anyway, it is not hard required.

You mean like with UPDATE_ADD_CONFLICT ?

Yes!

dzedro added 7 commits March 18, 2024 10:20
- get_patch will return list of patches
- print info of processed Modules, Packages, Patches and repos for better
  overview and easier debugging
Preinstall is trying to install all packages from patch at once, it can happen
not all pacakges can be installed at the same time
List of conflict pairs was created and packages in this list were just skipped
Now there is list of conflicting packages and this package will be patched first
alone and rest of packages will be patched without this conflict
I dropped many conflcits, most of them should be resolved by use of
zypper feature since 1.14 '--force-resolution --solver-focus Update'
There is separate SLE12 list becuase it's different than SLE15 and it should be
out of support in near future

- move the zypper version check at beginning
- remove conclict from l2 l3 result check, this is still broken with conflicts
- uninstall patch after conflicts and only if there are multiple patches
Required only for preinstall, conflict patch and uninstall of packages
Manually resolve patch conflict with RESOLVE_PATCH_CONFLICT variable
Tomcat is no shipped to SLED 15-SP4
Don't know better solution to exclude this case, just add this condition
- added wxWidgets conflict
- add solution argument to sle12_zypp_resolve and add variables for each use
  of this workaround
- add conflict for new binaries, needed for openssh on 12sp5 combined with use
  of UPDATE_ADD_CONFLICT and code which will add conflict to the list via
  this variable
- enable force-resolution feature on patch via UPDATE_PATCH_WITH_SOLVER_FEATURE
- add documentation for the variables

https://progress.opensuse.org/issues/155518
@dzedro dzedro changed the title Change conflict handling and add som features Change conflict handling and add some features Mar 18, 2024
@dzedro dzedro merged commit 41ca6a9 into os-autoinst:master Mar 18, 2024
10 checks passed
@dzedro dzedro deleted the update_conflict branch April 2, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qe-core Tag used to filter PR's created by QE-Core's members or are assigned to them Ready Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants