-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add installation and smoke test for SAP ASE #18583
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
f461e32
to
77628eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
5cea352
to
eba3341
Compare
New verification runs after applying fixes for the code review: 12-SP5: http://mango.qe.nue2.suse.org/tests/5665 |
Add test modules to install SAP ASE and to perform some smoke tests on the installed software: check that the server is running, query it to get the installed SAP ASE version, stop and start the database server, query the cockpit service status and stop and start the cockpit. Included with the test modules is a YAML schedule loading the new modules, and also the changes required for SAP ASE in `lib/sles4sap.pm`. Also included in the commit is the change from the deprecated `saptune daemon` commands to the new `saptune service` commands, and minor typo fixes and formatting to the POD documentation in `lib/sles4sap.pm`.
05e25a3
to
596d6e9
Compare
Add test modules to install SAP ASE and to perform some smoke tests on the installed software: check that the server is running, query it to get the installed SAP ASE version, stop and start the database server, query the cockpit service status and stop and start the cockpit.
Included with the test modules is a YAML schedule loading the new modules, and also the changes required for SAP ASE in
lib/sles4sap.pm
.Also included in the PR is the change from the deprecated
saptune daemon
commands to the newsaptune service
commands, and minor typo fixes and formatting to the POD documentation inlib/sles4sap.pm
.12-SP5: http://mango.qe.nue2.suse.org/tests/5662
15-SP2: http://mango.qe.nue2.suse.org/tests/5651
15-SP3: http://mango.qe.nue2.suse.org/tests/5652
15-SP4: http://mango.qe.nue2.suse.org/tests/5654
15-SP5: http://mango.qe.nue2.suse.org/tests/5663
15-SP6: http://mango.qe.nue2.suse.org/tests/5596 (Failure unrelated to this PR. SAP ASE is currently not installable in 15-SP6 due to bsc#1218200)
NetWeaver: http://mango.qe.nue2.suse.org/tests/5660
HANA: http://mango.qe.nue2.suse.org/tests/5661