Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installation and smoke test for SAP ASE #18583

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

alvarocarvajald
Copy link
Contributor

@alvarocarvajald alvarocarvajald commented Feb 2, 2024

Add test modules to install SAP ASE and to perform some smoke tests on the installed software: check that the server is running, query it to get the installed SAP ASE version, stop and start the database server, query the cockpit service status and stop and start the cockpit.

Included with the test modules is a YAML schedule loading the new modules, and also the changes required for SAP ASE in lib/sles4sap.pm.

Also included in the PR is the change from the deprecated saptune daemon commands to the new saptune service commands, and minor typo fixes and formatting to the POD documentation in lib/sles4sap.pm.

12-SP5: http://mango.qe.nue2.suse.org/tests/5662
15-SP2: http://mango.qe.nue2.suse.org/tests/5651
15-SP3: http://mango.qe.nue2.suse.org/tests/5652
15-SP4: http://mango.qe.nue2.suse.org/tests/5654
15-SP5: http://mango.qe.nue2.suse.org/tests/5663
15-SP6: http://mango.qe.nue2.suse.org/tests/5596 (Failure unrelated to this PR. SAP ASE is currently not installable in 15-SP6 due to bsc#1218200)

  • Regression tests:

NetWeaver: http://mango.qe.nue2.suse.org/tests/5660
HANA: http://mango.qe.nue2.suse.org/tests/5661

Copy link

github-actions bot commented Feb 2, 2024

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

lib/sles4sap.pm Outdated Show resolved Hide resolved
lib/sles4sap.pm Outdated Show resolved Hide resolved
tests/sles4sap/ase_test.pm Outdated Show resolved Hide resolved
Copy link
Contributor

@mpagot mpagot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lpalovsky lpalovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@BillAnastasiadis BillAnastasiadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvarocarvajald
Copy link
Contributor Author

lib/sles4sap.pm Show resolved Hide resolved
lib/sles4sap.pm Show resolved Hide resolved
tests/sles4sap/ase_install.pm Outdated Show resolved Hide resolved
tests/sles4sap/ase_install.pm Show resolved Hide resolved
tests/sles4sap/ase_test.pm Show resolved Hide resolved
Add test modules to install SAP ASE and to perform some smoke tests on
the installed software: check that the server is running, query it to
get the installed SAP ASE version, stop and start the database server,
query the cockpit service status and stop and start the cockpit.

Included with the test modules is a YAML schedule loading the new
modules, and also the changes required for SAP ASE in `lib/sles4sap.pm`.

Also included in the commit is the change from the deprecated
`saptune daemon` commands to the new `saptune service` commands, and
minor typo fixes and formatting to the POD documentation in
`lib/sles4sap.pm`.
@a-kpappas a-kpappas merged commit 19e6446 into os-autoinst:master Feb 14, 2024
9 checks passed
@alvarocarvajald alvarocarvajald deleted the sap-ase branch February 14, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants