Add more az cli wrappers for VM #19402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add more functions to manage VM.
mpagot
force-pushed
the
cloud_pacemaker_ipaddr2_az
branch
from
08551bc to
e5cf670
Compare
alvarocarvajald
approved these changes
May 28, 2024
| @@ -134,6 +134,11 @@ sub az_network_vnet_create { | |||
| croak("Argument < $_ > missing") unless $args{$_}; } | |||
| $args{address_prefixes} //= '192.168.0.0/16'; | |||
| $args{subnet_prefixes} //= '192.168.0.0/24'; | |||
| foreach (qw(address_prefixes subnet_prefixes)) { | |||
| croak "Invalid IP range $args{$_} in $_" | |||
| unless ($args{$_} =~ /^[1-9]{1}[0-9]{0,2}\.(0|[1-9]{1,3})\.(0|[1-9]{1,3})\.(0|[1-9]{1,3})\/[0-9]+$/); | |||
There was a problem hiding this comment.
There's is something that @lpalovsky is using in SDAF modules to check IP addresses format which could help here:
There was a problem hiding this comment.
Thanks, I'll give it a try in a next PR
dzedro
pushed a commit
to dzedro/os-autoinst-distri-opensuse
that referenced
this pull request
Jun 10, 2024
Add more functions to manage VM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more functions to manage VM.
Verification run: