Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Salt multimachine test for QAM #6185

Merged
merged 1 commit into from
Nov 15, 2018
Merged

Conversation

pdostal
Copy link
Member

@pdostal pdostal commented Nov 12, 2018

Good morning,

I wrote Salt stack multimachine test with one master and two minions.
The commands and states are called from master and verified on the other node.

@pdostal pdostal force-pushed the qam_salt branch 4 times, most recently from 13034a3 to 863dd86 Compare November 15, 2018 07:27
@pdostal pdostal force-pushed the qam_salt branch 3 times, most recently from 3efc888 to ec60d87 Compare November 15, 2018 08:48
@pdostal
Copy link
Member Author

pdostal commented Nov 15, 2018

Thank you, @dzedro, I think I fixed everything you mentioned 😄

@dzedro
Copy link
Contributor

dzedro commented Nov 15, 2018

Thank you, @dzedro, I think I fixed everything you mentioned smile

nothing was broken, nice improvement @pdostal 😉

@schlad
Copy link
Contributor

schlad commented Nov 15, 2018

Awesome. This comes handy as QA SLE is having a requirement to test some "tools" like salt etc. Thanks for this PR.

@pdostal pdostal changed the title WIP: Implement Salt multimachine test for QAM Implement Salt multimachine test for QAM Nov 15, 2018
@@ -1042,6 +1042,16 @@ else {
loadtest "network/openvpn_client";
}
}
elsif (get_var("QAM_SALT")) {
loadtest "boot/boot_to_desktop";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add loadtest 'qa_automation/patch_and_reboot' if is_updates_tests;. Also check if is possible use boot_hdd_image;.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome approach - thank you
I'd also suggest to go with boot_hdd_image if possible

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I implemented that. However I had to set the network before the patch_and_reboot test but it's IMO not big difference. See my openqa.

@dzedro
Copy link
Contributor

dzedro commented Nov 15, 2018

just note: patch and reboot should be done while disk image is created, now we will do patch and reboot in every test, n times, when it could be done once ...

@czerw czerw merged commit 13f0cd2 into os-autoinst:master Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants