New tests and bug fixes #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing test was adding a matrix of an incompatible shape, which doesn't test the intended code path.
Uses a setup fixture that generates a test file name using the tempfile module and a teardown fixture that deletes the file after each test is complete.
This ensures that all the files are properly closed when the tests are done with them.
To eliminate the from nose.tools import *
These tend to give more useful error messages than plain asserts.
Need to search self.root.data, not self.root, for nodes.
Stops this warning from appearing when using openmatrix: File.py:30: FutureWarning: comparison to `None` will result in an elementwise object comparison in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a bit of work when going through the exercise of incorporating OMX into ActivitySim (ActivitySim/activitysim#7) and thought they might be appreciated here. The largest changes are increased test coverage and bug fixes.
File.listAllAttributesthat caused it to always return[]is/is notfor comparisons toNoneso we don't get a warning from tables