Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Since the commit 4824ac3 ("Skip tests based on SKIP_REASON, not return value"), blktests no longer checks return values of _have_foo helpers. Instead, it checks if _have_foo helpers set SKIP_REASON, which was renamed to SKIP_REASONS later, to judge test case skip. If two _have_foo helpers are chained with ||, the skip check does not work as expected since one of the helper may set SKIP_REASONS even when the other does not set. Such chain with || is done in _nvme_requires() to check rdma drivers. To fix the check, do not chain the helper functions with || operator. Instead, refer $use_rxe to call only the required function. Reviewed-by: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
- Loading branch information