-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bib: allow blueprints in toml as well #392
Conversation
I expressed a preference for toml to make life easier for adding kickstart files (see osbuild/images#631). What I'd like to see, either in this PR or a follow-up:
The latest one should be a followup |
3db0b40
to
ac2e650
Compare
This commit adds support to load blueprints from toml as well.
ac2e650
to
7ad75e5
Compare
I have one suggestion on this feature. It will be wonderful to align this toml configuration file with toml file used by osbuild-composer. So the osbuild-composer Blueprint Refreence can be re-used as a reference. Thanks! |
Move from config.json -> config.toml in the example(s) in th README.md. Also remove the `--config` as bib will search for /config.{json,toml} automatically.
78a2c2a
to
8e20587
Compare
Tiny integration test that ensures config.toml is honored during manifest generation.
8e20587
to
be9be2f
Compare
Since we use a very limited number of options here, it might be better to have a dedicated page for BIB. Or maybe we could add a third bubble colour for |
I have a branch ready for this in https://github.com/osbuild/bootc-image-builder/compare/main...mvo5:use-toml-blueprints-compat?expand=1 - it also keeps the legacy format compatiblity for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent. LGTM!
This commit adds support to load blueprints from toml as well.
[draft as tests are missing]