-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wizard: Debounce unique validation (HMS-4581) #2374
Conversation
b200429
to
392fd32
Compare
/retest |
1 similar comment
/retest |
/retest |
5 similar comments
/retest |
/retest |
/retest |
/retest |
/retest |
The debounce works great, found one edge case - if the user is fast enough they can input already existing name and skip to Review before the validation error shows: They get the error on the next step and need to fix it before creating a blueprint so all's safe. But would it be possible to disable the Next button until validation finishes somehow maybe? |
392fd32
to
13fa6c1
Compare
Sure :) here we go ;) |
Debounce the validation, so we don't validate every character. Debounce also ensures the right ordering. Only one request runs at a time, we cancel the previous before we fire a new.
13fa6c1
to
47b8e8f
Compare
Beautiful, thank you! This has similar problem with pristinity as #2305, see #2305 (comment). But I think we should take a look at it separately. Even though we have control over pristinity in this case I think we should keep the way we communicate validation issue consistent throughout wizard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works really well, thank you!
Debounce the validation, so we don't validate every character. Debounce also ensures the right ordering.
Only one request runs at a time, we cancel the previous before we fire a new.