test: Move and cleanup OpenSCAP tests (HMS-4658) #2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regexowl
force-pushed
the
move-and-cleanup-compliance-tests
branch
from
026375b
to
d7b59eb
Compare
mgold1234
force-pushed
the
move-and-cleanup-compliance-tests
branch
from
d7b59eb
to
bfae3f2
Compare
regexowl
changed the title
regexowl
force-pushed
the
move-and-cleanup-compliance-tests
branch
from
bfae3f2
to
e0c90c5
Compare
regexowl
force-pushed
the
move-and-cleanup-compliance-tests
branch
from
e0c90c5
to
979198d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #2391 +/- ##
==========================================
+ Coverage 75.71% 83.64% +7.93%
==========================================
Files 33 153 +120
Lines 597 17235 +16638
Branches 144 1673 +1529
==========================================
+ Hits 452 14416 +13964
- Misses 139 2800 +2661
- Partials 6 19 +13 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
regexowl
force-pushed
the
move-and-cleanup-compliance-tests
branch
from
979198d
to
8718f16
Compare
regexowl
force-pushed
the
move-and-cleanup-compliance-tests
branch
from
8718f16
to
5609003
Compare
This moves OpenSCAP tests from `CreateImageWizard.compliance.tsx` test file directly to `Oscap.test.tsx`.
This cleans up OpenSCAP test file, utilising helper functions we already have and updating names of test and describe blocks to be consistent throughout the test files.
regexowl
force-pushed
the
move-and-cleanup-compliance-tests
branch
from
5609003
to
dd4bda8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves OpenSCAP tests to
Oscap.test.tsxand cleans them up.