HMS-4667: Blueprints: Allow importing without subscription

[avitova]

This requires a small change on our backend - on export endpoint, we would need to export "subscription: {}" in the customizations field, so that we can detect that a subscription was there, when we import the blueprint back. :)
Let's not merge before we merge the backend change.

All information is in the ticket. But TLDR; we omit subscription now, and because of that, we can not detect if the blueprint was subscribed or not.

[codecov]

Codecov Report

Attention: Patch coverage is 92.64706% with 5 lines in your changes missing coverage. Please review.

Project coverage is 83.62%. Comparing base (1a7350e) to head (e7ae887).
Report is 2154 commits behind head on main.

Files with missing lines	Patch %	Lines
...nents/CreateImageWizard/utilities/requestMapper.ts	91.93%	5 Missing ⚠️

@@            Coverage Diff             @@
##             main    #2434      +/-   ##
==========================================
+ Coverage   75.71%   83.62%   +7.91%     
==========================================
  Files          33      153     +120     
  Lines         597    17248   +16651     
  Branches      144     1668    +1524     
==========================================
+ Hits          452    14424   +13972     
- Misses        139     2805    +2666     
- Partials        6       19      +13     

Files with missing lines	Coverage Δ
src/Components/Blueprints/ImportBlueprintModal.tsx	85.81% <100.00%> (ø)
...nents/CreateImageWizard/utilities/requestMapper.ts	94.16% <91.93%> (ø)

... and 2 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dca94cb...e7ae887. Read the comment docs.

[avitova]

/retest

[amirfefer]

Thanks, @avitova! 👍

I have a quick thought: Would it make sense to open the wizard directly on the subscription step when no subscription is present? This could help guide users more intuitively.

I've also left a few minor nitpicks.

[amirfefer]

nit: The findByText is already a promise that waits, so no need to wrap it in a WaitFor

await expect(
  screen.findByText('Image output', { selector: 'h1' })
).resolves.toBeInTheDocument();

// or
const element = await screen.findByText('Image output', { selector: 'h1' });
expect(element).toBeInTheDocument();

[amirfefer]

Makes sense to use default values when no uploadOption exists. 👍

[amirfefer]

Just to make this more structure and readable, we could first create a subscriptionState object, using the subscribed flag just once.

  const subscriptionState = subscribed
    ? {
        serverUrl: request.customizations.subscription?.['server-url'] || initialState.env.serverUrl,
        baseUrl: request.customizations.subscription?.['base-url'] || initialState.env.baseUrl,
        registrationType: request.customizations.subscription
          ? request.customizations.subscription.rhc
            ? 'register-now-rhc'
            : 'register-now-insights'
          : initialState.registration.registrationType,
        activationKey: request.customizations.subscription?.['activation-key'] || initialState.registration.activationKey,
      }
    : {
        serverUrl: '',
        baseUrl: '',
        registrationType: 'register-later' as const,
        activationKey: '',
      };

and return

  return {

    // ...metadata...

    env: {
      serverUrl: subscriptionState.serverUrl,
      baseUrl: subscriptionState.baseUrl,
    },
    registration: {
      registrationType: subscriptionState.registrationType,
      activationKey: subscriptionState.activationKey,
    },
    ...commonRequestToState(blueprintResponse),

[avitova]

After discussions about the customer value of this solution, I am closing this pull request. Any details can be found in the backend pull request that is related to this one: ib backend #1343