Test: rebuild disks from bootable containers when the BIB container changes #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achilleas-k
force-pushed
the
test/log-bib-image-id
branch
from
d1a5e9e
to
1dee9db
Compare
|
Requested review from @mvo5 because tests ^_^ |
achilleas-k
force-pushed
the
test/log-bib-image-id
branch
6 times, most recently
from
e13c028
to
5323a15
Compare
|
Okay, the bib test failed. This is good :) |
mvo5
reviewed
Jan 29, 2024
|
Current status: The image doesn't build with BIB since we switched to using bootupd. The metadata isn't part of our base image. This was expected (and the reason I added the test in the first place). Working on adding this now. |
This was referenced Feb 3, 2024
achilleas-k
force-pushed
the
test/log-bib-image-id
branch
from
1e18012
to
79cfb2d
Compare
|
Rebased. Should be good to go! |
skopeo_inspect_id() can inspect a container image (local or remote) and return the image ID for a given architecture. When inspecting local containers, it uses sudo to access the root container registry, which is what we use in tests for the bib container. The host_container_arch() function returns a string that matches the expected arch name for the host.
The tests check the manifest-list test container we keep in the gitlab registry for tests in osbuild-composer and in this repository. Test that: - Inspecting the manifest list at :latest returns the expected image ID. - Inspecting the manifest digest for a given architecture returns the expected image ID. - Pulling a container and inspecting the local storage for a given architecture returns the expected image ID. The local storage inspection will run 'skopeo inspect' with sudo, so the test only runs when sudo can be run non-interactively (sudo -n).
We will use this ID to retest bootable container images when the bib container changes to ensure we maintain compatibility.
If the container image ID changes, rebuilds and retest bootable container images.
The test fails in github actions but it's useful to keep until we fix it. Mark it as disabled and keep a comment to investigate.
achilleas-k
force-pushed
the
test/log-bib-image-id
branch
from
79cfb2d
to
0dbe367
Compare
ondrejbudai
approved these changes
Feb 10, 2024
| transport = "containers-storage:" | ||
| image = "registry.gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/manifest-list-test:latest" | ||
| with tempfile.TemporaryDirectory() as tmpdir: | ||
| testlib.runcmd(["sudo", "podman", "pull", f"--arch={arch}", "--storage-driver=vfs", f"--root={tmpdir}", image]) |
There was a problem hiding this comment.
--storage-driver=vfs is so we can run the test in a container, right? It might be worth leaving a small note about that here, it might not be obvious to future readers.
EDIT from future Ondrej who read all commits: So it apparently doesn't work in a container... weird...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write the bootc-image-builder container ID that we used to build a disk image and boot test bootable containers. We use this ID to retest bootable container images when the bib container changes to ensure we maintain compatibility.