osbuild: add support for partscan/partition #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for `partscan` in `org.osbuild.loopback`. The coresponding osbuild option was added in osbuild/osbuild#1501
This commit adds support for the `partition` feature in mounts that enumerates partitions from loopback devices that use the `partscan` feature. See osbuild/osbuild#1501 for the coresponding osbuild PR.
cgwalters
approved these changes
Jan 30, 2024
achilleas-k
approved these changes
Feb 7, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tiny PR that will probably be needed to integrate with osbuild/osbuild#1547
In the work on
bootc install to-filesystemso far it expects a view of the entire disk (for bootupd). However in #381 with the standalone bootupd integration it was not needed. We can wait with the merge until the osbuild PR is merged and we test this more meaningfully. OTOH it's tiny and does not hurt to have (as there is a coresponding osbuild feature).The corresponding osbuild PR is osbuild/osbuild#1501
P.S. I can remove osbuild: move mount_test.go to osbuild_test pattern is that is undesired (I'm a fan of this pattern but I get that not everyone is :)