Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disk(ova): correct archive order #426

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

croissanne
Copy link
Member

@croissanne croissanne commented Feb 6, 2024

ovf, mf, vmdk.

Fix #431

@croissanne croissanne requested review from achilleas-k and thozza and removed request for achilleas-k February 6, 2024 13:49
@croissanne croissanne changed the title disk(ova): correct archive order RHEL-22199 disk(ova): correct archive order Feb 6, 2024
Schutzfile Outdated Show resolved Hide resolved
achilleas-k
achilleas-k previously approved these changes Feb 6, 2024
Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet. LGTM!

Schutzfile Outdated Show resolved Hide resolved
@achilleas-k
Copy link
Member

Changing the osbuild commit ID means all the images are being rebuilt which is a problem because the Fedora iot-bootable-container test is broken. Needs #427.
We can disable the test if this is a priority and I'll enable it in the fix PR.

@achilleas-k
Copy link
Member

Rebased and dropped the Schutzfile osbuild commit bump since it's been already updated in #427.

@achilleas-k achilleas-k added this pull request to the merge queue Feb 8, 2024
Merged via the queue into osbuild:main with commit 1709a76 Feb 8, 2024
12 checks passed
@croissanne croissanne deleted the ova-archive-order branch February 8, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OVA file order and checksum issues
3 participants