container: make container.NewResolver() return a pointer
#433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most go packages return pointers to structs when using `NewFoo()`. But `NewResolver()` does not and AFAICT there is no deep reason for this. I would prefer to return a pointer here, I got tripped up by this in osbuild/bootc-image-builder#139 (comment)
This was referenced Feb 8, 2024
achilleas-k
approved these changes
Feb 8, 2024
|
Ready to merge if you want to mark it ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most go packages return pointers to structs when using
NewFoo(). ButNewResolver()does not and AFAICT there is no deep reason for this. I would prefer to return a pointer here, I got tripped up by this inosbuild/bootc-image-builder#139 (comment)
This will be the first part to fix osbuild/bootc-image-builder#139 (comment)
I checked the various uses of container.NewResolver() and this does not even seem to require any code change in the current consumers.