Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmdutil: print rng TEST MODE... warning to stderr #892

Merged
merged 1 commit into from
Sep 2, 2024
Merged

cmdutil: print rng TEST MODE... warning to stderr #892

merged 1 commit into from
Sep 2, 2024

Conversation

mvo5
Copy link
Contributor

@mvo5 mvo5 commented Sep 2, 2024

Printing on stdout interferes with the json output from otk-gen-partition-table.

@mvo5
cmdutil: print rng TEST MODE... warning to stderr
5adc55b 
Printing on stdout interferes with the json output from
`otk-gen-partition-table`.
achilleas-k
achilleas-k approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

Maybe it would be better if utility functions weren't printing at all, or were using a logger with warning/error levels. But for now, let's merge this as is.

@achilleas-k achilleas-k added this pull request to the merge queue Sep 2, 2024
Merged via the queue into osbuild:main with commit 3646aff Sep 2, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achilleas-k achilleas-k achilleas-k approved these changes

Assignees
No one assigned
Labels
🍼 Simple
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvo5 @achilleas-k