-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] gen-manifests: add excluded packages via exclude:
prefix in mock
#938
Conversation
This commit adds excluded packages to the generated manifest when the `gen-manifests` command is run in the `mockDepsolve()` mode. This allows us to compare the generated otk and images manifests with more confidence.
234ad9e
to
fbde851
Compare
exclude-
prefix in mockexclude:
prefix in mock
This commit regenerates the reference images with the new `exclude:` prefix as outlined in osbuild/images#938
This commit follows osbuild/images#938 and adjust the way excludes are represented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to return these in the list of package specs? We wouldn't normally get that information from the depsolver as the packages are excluded so I feel like a list of package names is enough here?
Maybe I'm misunderstanding what you are saying but if we just add the excluded package names as "normal" packages to the resolver we would not catch differences like "images" includes "pkg1" but "otk" excludes "pkg1". In both cases it would appear in the package list so I think we need some prefix/marker/thing that ensures they are different. Plus this is very explicit. But open for ideas of course. |
If I understand your question correctly, the current patch should include this. Meaning, the list of package specs (the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to suggest we also include 1767b44 here, but that's not as useful since the version numbers of excluded packages don't matter.
LGTM
This commit regenerates the reference images with the new `exclude:` prefix as outlined in osbuild/images#938
This commit follows osbuild/images#938 and adjust the way excludes are represented.
This commit follows osbuild/images#938 and adjust the way excludes are represented.
This commit regenerates the reference images with the new `exclude:` prefix as outlined in osbuild/images#938
This commit follows osbuild/images#938 and adjust the way excludes are represented.
This commit adds excluded packages to the generated manifest when the
gen-manifests
command is run in themockDepsolve()
mode.This allows us to compare the generated otk and images manifests with more confidence.