Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GetJuliaScratchspace to JuliaInterface #1030

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

ThomasBreuer
Copy link
Member

This is the non-controversial part of #1026.

@ThomasBreuer ThomasBreuer added the kind: enhancement New feature or request label Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.75%. Comparing base (a8674da) to head (8d8c8cb).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/utils.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1030      +/-   ##
==========================================
+ Coverage   76.73%   76.75%   +0.02%     
==========================================
  Files          51       51              
  Lines        4182     4191       +9     
==========================================
+ Hits         3209     3217       +8     
- Misses        973      974       +1     
Files with missing lines Coverage Δ
pkg/JuliaInterface/gap/JuliaInterface.gd 100.00% <100.00%> (ø)
pkg/JuliaInterface/gap/JuliaInterface.gi 94.39% <100.00%> (+0.39%) ⬆️
src/utils.jl 48.48% <0.00%> (-1.52%) ⬇️

@fingolfin

This comment was marked as resolved.

pkg/JuliaInterface/gap/JuliaInterface.gd Outdated Show resolved Hide resolved
pkg/JuliaInterface/gap/JuliaInterface.gd Outdated Show resolved Hide resolved
pkg/JuliaInterface/gap/JuliaInterface.gi Outdated Show resolved Hide resolved
@fingolfin fingolfin merged commit 35d7fa1 into oscar-system:master Sep 4, 2024
21 checks passed
@ThomasBreuer ThomasBreuer deleted the TB_scratch_helper branch September 4, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants