Reduce implicit dependencies on GAP packages #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wonderful! |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #909 +/- ##
==========================================
+ Coverage 75.55% 75.57% +0.01%
==========================================
Files 51 51
Lines 4160 4163 +3
==========================================
+ Hits 3143 3146 +3
Misses 1017 1017
|
ThomasBreuer
approved these changes
Jun 30, 2023
These changes avoid some direct or indirect access to functionality provided by GAP packages (namely CTblLib, GAPDoc, SmallGrp).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes avoid some direct or indirect access to functionality
provided by GAP packages (namely CTblLib, GAPDoc, SmallGrp).
The ultimate goal is to switch GAP.jl to start GAP with
-Aor even--bare(or something equivalent) and then leave it to users to loadpackages. We could also have a
GAP_full.jlor so which loadsGAP.jland all default packages etc., but that's all very hypothetical: These
changes are harmless either way, even if everything else stays as it is.