replace GAPTable for char. tables by GapObj

oscar-system · May 3, 2024 · 8093527 · 8093527
1 parent 40ed335
commit 8093527
Show file tree

Hide file tree

Showing 5 changed files with 86 additions and 86 deletions.
diff --git a/experimental/GModule/GModule.jl b/experimental/GModule/GModule.jl
@@ -612,7 +612,7 @@ function Oscar.natural_character(C::GModule{<:Any, <:AbstractAlgebra.FPModule{<:
 
   vals = [GAP.Globals.BrauerCharacterValue(GAP.Obj(map(h, matrix(action(C, representative(x)))))) for x in ccl]
 
-  return Oscar.class_function(modtbl, GAPWrap.ClassFunction(Oscar.GAPTable(modtbl), Oscar.GapObj(vals)))
+  return Oscar.class_function(modtbl, GAPWrap.ClassFunction(GapObj(modtbl), GapObj(vals)))
 end
 
 function Oscar.sub(C::GModule{<:Any, <:AbstractAlgebra.FPModule{T}}, m::MatElem{T}) where {T <: FinFieldElem}

diff --git a/experimental/OrthogonalDiscriminants/src/utils.jl b/experimental/OrthogonalDiscriminants/src/utils.jl
@@ -150,10 +150,10 @@ function possible_permutation_characters_from_sylow_subgroup(tbl::Oscar.GAPGroup
   pos != nothing && return [induced_cyclic(tbl, [pos])[1]]
 
   # Do we have the table of marks?
-  tom = GAP.Globals.TableOfMarks(Oscar.GAPTable(tbl))
+  tom = GAP.Globals.TableOfMarks(GapObj(tbl))
   if tom != GAP.Globals.fail
     pos = findfirst(x -> x == q, Vector{Int}(GAP.Globals.OrdersTom(tom)))
-    return [Oscar.class_function(tbl, GAP.Globals.PermCharsTom(Oscar.GAPTable(tbl), tom)[pos])]
+    return [Oscar.class_function(tbl, GAP.Globals.PermCharsTom(GapObj(tbl), tom)[pos])]
   end
 
   # Does the table have a nontrivial 'p'-core
@@ -193,7 +193,7 @@ function possible_permutation_characters_from_sylow_subgroup(tbl::Oscar.GAPGroup
             for i in npos
               pi[i] = index
             end
-            pi = GAP.Globals.ClassFunction(Oscar.GAPTable(s), GapObj(pi, true))
+            pi = GAP.Globals.ClassFunction(GapObj(s), GapObj(pi, true))
             return [Oscar.class_function(s, pi)^tbl]
           else
             # Try to recurse.
@@ -219,7 +219,7 @@ function possible_permutation_characters_from_sylow_subgroup(tbl::Oscar.GAPGroup
               pi = GAP.Globals.CompositionMaps(GapObj(pi),
                        GAP.Globals.InverseMap(GapObj(fus)))
               union!(extcand, [Oscar.class_function(tbl, x) for x in
-                                GAP.Globals.PermChars(Oscar.GAPTable(tbl),
+                                GAP.Globals.PermChars(GapObj(tbl),
                                   GapObj(Dict(:torso => pi), true))])
             end
             if candlist == nothing

diff --git a/experimental/SymmetricIntersections/src/representations.jl b/experimental/SymmetricIntersections/src/representations.jl
@@ -234,7 +234,7 @@ end
 Given a class function `chi` on a group `G`, return whether `chi` defines a
 character of `G` (over its codomain).
 """
-is_character(chi::Oscar.GAPGroupClassFunction) = GG.IsCharacter(GAPTable(parent(chi)), GapObj(chi))::Bool
+is_character(chi::Oscar.GAPGroupClassFunction) = GG.IsCharacter(GapObj(parent(chi)), GapObj(chi))::Bool
 
 @doc raw"""
     is_constituent(chi::T, nu::T) where T <: Oscar.GAPGroupClassFunction -> Bool