Remove functions moved to Nemo (Nemocas/Nemo.jl#1519)

oscar-system · Sep 14, 2023 · fdd951b · fdd951b
1 parent 4217f1b
commit fdd951b
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 8 deletions.
diff --git a/experimental/GModule/GModule.jl b/experimental/GModule/GModule.jl
@@ -1095,9 +1095,6 @@ function hom_base(C::GModule{<:Any, <:AbstractAlgebra.FPModule{nf_elem}}, D::GMo
   end
 end
 
-#T this belongs to Nemo and should be moved there
-Oscar.nbits(a::QQFieldElem) = nbits(numerator(a)) + nbits(denominator(a))
-
 function hom_base(C::_T, D::_T) where _T <: GModule{<:Any, <:AbstractAlgebra.FPModule{QQFieldElem}}
   @assert base_ring(C) == base_ring(D)
 

diff --git a/src/Rings/AlgClosureFp.jl b/src/Rings/AlgClosureFp.jl
@@ -129,11 +129,6 @@ function op(f::Function, a::AlgClosureElem, b::AlgClosureElem)
   return f(k(ad), k(bd))
 end
 
-#T the following belongs to Nemo and should be moved there
-function Oscar.embed(k::Nemo.fpField, K::fqPolyRepField)
-  @assert characteristic(K) == characteristic(k)
-end
-
 +(a::AlgClosureElem, b::AlgClosureElem) = AlgClosureElem(op(+, a, b), parent(a))
 -(a::AlgClosureElem, b::AlgClosureElem) = AlgClosureElem(op(-, a, b), parent(a))
 #TODO: do we really want to support different types here? (implies different parents)