Enable attribute storing for group products #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fieker
approved these changes
Apr 27, 2022
ThomasBreuer
approved these changes
Apr 27, 2022
|
Thanks! Tests are failing though |
fingolfin
force-pushed
the
mh/group-product-attributes
branch
from
249e590 to
0961012
Compare
|
There is an error in the Matroid code: https://github.com/oscar-system/Oscar.jl/runs/6191061211?check_suite_focus=true#step:5:178 pinging @bschroter |
|
The issue seems to be in the memory management. The parent object of Maybe @benlorenz knows how to fix this issue quickly. |
Closed
|
I have moved it to #1284 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new test failed before because the isomorphisms couldn't be stored