Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade selected GAP packages at startup #3222

Merged
merged 3 commits into from
Jan 26, 2024
Merged

upgrade selected GAP packages at startup #3222

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df91840
upgrade selected GAP packages at startup
ThomasBreuer Jan 23, 2024
b83b4e6
workaround for a `Downloads.Downloader` problem in Julia 1.10
ThomasBreuer Jan 25, 2024
53970dd
request GAP.jl 0.10.2 instead of the workaround
ThomasBreuer Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/Oscar.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,21 @@ function __init__()
GAP.Globals.BindGlobal(GapObj("Oscar"), Oscar)
GAP.Globals.SetPackagePath(GAP.Obj("OscarInterface"), GAP.Obj(joinpath(@__DIR__, "..", "gap", "OscarInterface")))
GAP.Globals.LoadPackage(GAP.Obj("OscarInterface"))
# Work around a problem in Julia 1.10 (see https://github.com/oscar-system/Oscar.jl/pull/3222).
isdefined(GAP.Packages.Downloads, :default_downloader!) && GAP.Packages.Downloads.default_downloader!(GAP.Packages.Downloads.Downloader(grace=0.01))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just release GAP.jl 0.10.2 so you could remove this and update Project.toml instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks.

withenv("TERMINFO_DIRS" => joinpath(GAP.GAP_jll.Readline_jll.Ncurses_jll.find_artifact_dir(), "share", "terminfo")) do
GAP.Packages.load("browse"; install=true) # needed for all_character_table_names doctest
end
# We want newer versions of some GAP packages than the distributed ones.
# (But we do not complain if the installation fails.)
for (pkg, version) in [
("repsn", "3.1.1"),
]
GAP.Packages.install(pkg, version, interactive = false, quiet = true)
end
isdefined(GAP.Packages.Downloads, :default_downloader!) && GAP.Packages.Downloads.default_downloader!()

# We need some GAP packages.
for pkg in [
"atlasrep",
"ctbllib", # character tables
Expand Down
Loading