-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make experimental packages more self-contained #3409
Make experimental packages more self-contained #3409
Conversation
@lgoettgens I am not really sure why this should be in 1.0, it is mostly meant to help keep the code-bases separate but there will not be much further development on the release branch. Moving lots of stuff around now seems not helpful for the release. |
Yes, you are right. I think my intention was to reduce the number of potential conflicts occurring while backporting |
Maybe it would make sense to wait with merging this PR until we are done with most of the backporting, to avoid any conflicts, both for master and for the backports. |
Yeah, waiting a few more days until all of the feature backports are done is more than fine. The minor doc changes later shouldn't become an issue with conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
I changed it to draft so that we don't accidentally merge this right now, we can change it back some time next week I guess. |
What is the motivatio to further tinker with the experimental stuff? As far as I can see: it works. |
Please see #3408 for the motivation. And let's keep the fundamental discussion there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this.
1e8a597
to
c5be6d6
Compare
c5be6d6
to
ec3bfde
Compare
Since 1.0 is now released and the bulk of backports is done, I think we could continue with this. |
d510d5b
to
2051bdf
Compare
2051bdf
to
dc6a0f0
Compare
Can we get this merged before any more conflicts come up? |
Resolves the first bullet point in the list in #3408.
With this PR, removing an experimental project is now as easy as deleting the corresponding folder in
experimental/
(and maybe removing it fromoldexppkgs
ororderedpkgs
inexperimental/Experimental.jl
), in particularusing Oscar
andAqua.test_undefined_exports(Oscar)
succeed. The exemption isexperimental/Rings/
which, currently, needs to be available for Oscar to load.Tests in general, will not work yet, see #3408 for a roadmap on how to achieve that.
This PR does not change any current behaviour/exports/deprecations/etc., it just moves them to a more suited places.