Replace many uses of G.X
by GapObj(X)
#3671
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... so that ultimately we can refactor the underpinnings of GAPGroup etc. -- initially by dropping those slightly evil
getproperty
methods that produceG.X
on demand.In the future this enables other refactoring. E.g. we could contemplate adding a mechanism where one could replace
GAPWrap.Foo(GapObj(x))
byGAPWrap.Foo(x)
(namely: whenever the wrapper specifies that an argument must be aGapObj
, as in e.g.GAP.@wrap ClassNames(x::GapObj)::GapObj
-- then the generated wrapper may as well assume it has to convert anything else toGapObj
.Anyway: this PR does not strive to eliminate all accesses to
.X
-- first off, some of them are of course legit. Secondly, this is already very big and I'd rather resolve a large chunk of the issue now, before delaying this further and having to deal with merge conflicts...