-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lie algebras] misc bugfixes, root system in Lie alg interface, dim_of_simple_module
implementation in julia
#4030
Merged
lgoettgens
merged 14 commits into
oscar-system:master
from
lgoettgens:lg/Lie-algebra-misc
Aug 21, 2024
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
9b3aca6
Add `!` to `set_root_system_type`
lgoettgens 56d036b
Add `has_root_system` to Lie algebra interface
lgoettgens 884d429
Enhance some root system tests
lgoettgens 80ca42c
Add `root_system` to Lie algebra interface
lgoettgens 210ddaf
Add missing `@attr`
lgoettgens df65a6a
Implement `dim_of_simple_module` in julia (in some cases)
lgoettgens 683e9b3
Revert "Skip one excessive test"
lgoettgens 764a62a
Test some more code paths in `dim_of_simple_module`
lgoettgens 746ac41
Move `dim_of_simple_module` to the root system
lgoettgens 50c7982
Remove `is_integral`
lgoettgens 9774f8f
Copy fix for `id \in W`
lgoettgens 2d1c537
Cache `cartan_symmetrizer`
lgoettgens 7ea927d
Make root system interface a bit clearer
lgoettgens b08d84f
Update experimental/LieAlgebras/src/AbstractLieAlgebra.jl
lgoettgens File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this function was only moved, why was the doc string deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docstring is now attached to
chevalley_basis(::LieAlgebra)
, as it contained nothing specific for the Lie algebra subtype