Skip to content

Commit

Permalink
prepare for cxxwrap 0.16 (and polymake 4.13) (#500)
Browse files Browse the repository at this point in the history 
* prepare for cxxwrap 0.16

* allow more versions

* CI: test different cxxwrap versions

* version 0.11.22
  • Loading branch information
@benlorenz
benlorenz authored Oct 2, 2024
1 parent b522ba5 commit f87c7d2
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 5 deletions.
10 changes: 9 additions & 1 deletion .github/workflows/runtests.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
- '1.11-nightly'
- 'nightly'
os: ['ubuntu-latest']
cxxwrap: [ '' ]
cxxwrap: [ '0.14', '0.16' ]

fail-fast: false
# Service containers to run
Expand Down Expand Up @@ -101,9 +101,14 @@ jobs:
- '1.11-nightly'
- 'nightly'
os: [ 'macos-14' ] # aarch64
cxxwrap: [ '' ]
include:
- os: 'macos-13' # x86_64
julia-version: '1.6'
cxxwrap: ''
- os: 'macos-14' # x86_64
julia-version: '1.10'
cxxwrap: '0.14'
fail-fast: false

steps:
Expand All @@ -117,6 +122,9 @@ jobs:
cache-name: julia-cache;workflow=${{ github.workflow }};julia=${{ matrix.julia-version }};arch=${{ runner.arch }}
include-matrix: false
cache-scratchspaces: false
- name: "pin CxxWrap"
if: matrix.cxxwrap != ''
run: julia --project -e 'using Pkg; pkg"add CxxWrap@${{ matrix.cxxwrap }}"; pkg"pin CxxWrap";'
- uses: julia-actions/julia-runtest@v1
- uses: julia-actions/julia-processcoverage@v1
- uses: codecov/codecov-action@v4
Expand Down
6 changes: 3 additions & 3 deletions Project.toml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "Polymake"
uuid = "d720cf60-89b5-51f5-aff5-213f193123e7"
repo = "https://github.com/oscar-system/Polymake.jl.git"
version = "0.11.21"
version = "0.11.22"

[deps]
AbstractAlgebra = "c3fe647b-3220-5bb0-a1ea-a7954cac585d"
Expand All @@ -28,7 +28,7 @@ polymake_oscarnumber_jll = "10f31823-b687-53e6-9f29-edb9d4da9f9f"
[compat]
AbstractAlgebra = "~0.40.8, ~0.41, ~0.42, ~0.43"
BinaryWrappers = "~0.1.0"
CxxWrap = "~0.14"
CxxWrap = "~0.14, ~0.16"
Downloads = "^1.4"
JSON = "^0.20, ^0.21"
Libdl = "^1.6"
Expand All @@ -44,6 +44,6 @@ SparseArrays = "^1.6"
TOPCOM_jll = "~0.17.8"
julia = "^1.6"
lib4ti2_jll = "^1.6.10"
libpolymake_julia_jll = "~0.12.1"
libpolymake_julia_jll = "~0.12.1, ~0.13.0"
polymake_jll = "^400.1200.0"
polymake_oscarnumber_jll = "~0.3.1"
2 changes: 1 addition & 1 deletion src/Polymake.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ import TOPCOM_jll
using libpolymake_julia_jll
using polymake_oscarnumber_jll

const jlpolymake_version_range = (v"0.12.0", v"0.13")
const jlpolymake_version_range = (v"0.12.0", v"0.14")

struct PolymakeError <: Exception
msg
Expand Down

2 comments on commit f87c7d2

@benlorenz
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register()

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/116459

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.11.22 -m "<description of version>" f87c7d2b00680604080cc8092c4489e238c9a0f1
git push origin v0.11.22

Please sign in to comment.