Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: limit concurrency for update-contrib workflow #397

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

fingolfin
Copy link
Member

If multiple PRs are merged into master in a row, we don't want them all to run, just the one on the latest commit.

@fingolfin fingolfin requested a review from aaruni96 December 4, 2024 20:51
@aaruni96
Copy link
Member

aaruni96 commented Dec 4, 2024

Great idea, but I will have to dive into the documentation for concurrency to actually review the change.

Just to confirm, since the action only runs when a someone pushes to gh-pages (so, after a regular PR is merged), and if multiple PRs are merged in a short succession, we cancel the ones still in progress, and only keep the run on the latest commit on gh-pages. This is what your change will do, right ?

@fingolfin
Copy link
Member Author

Yes. We use something similar in Oscar.jl's CI.yml. The code in this PR is a bit different though and copied from https://github.com/gap-system/PackageDistro/blob/main/.github/workflows/assemble-distro.yml (where it has been in extensive use for quite some time)

Copy link
Member

@aaruni96 aaruni96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@aaruni96 aaruni96 merged commit 466ec26 into oscar-system:gh-pages Dec 5, 2024
@fingolfin fingolfin deleted the mh/CI-limit-concurrency branch December 12, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants