Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sendable #70

Closed
oscbyspro opened this issue Apr 7, 2023 · 3 comments
Closed

Sendable #70

oscbyspro opened this issue Apr 7, 2023 · 3 comments
Labels
addition oh, so shiny!
Milestone

Comments

@oscbyspro
Copy link
Owner

oscbyspro commented Apr 7, 2023

ANKFullWidth and ANKSigned should conform to Sendable. I kind of assumed they already did because they are frozen structs with Sendable properties ...oh, wait, their properties are generic and lack a Sendable constraint. Well, that's a bit of an oversight, but easily fixed. My main consideration is whether I should require all ANKBinaryInteger(s) to be Sendable. Is there an integer model that shouldn't be Sendable?

@oscbyspro oscbyspro added the addition oh, so shiny! label Apr 7, 2023
@oscbyspro oscbyspro added this to the v1.0.0 milestone Apr 7, 2023
@oscbyspro
Copy link
Owner Author

oscbyspro commented Apr 7, 2023

let withStrictConcurrency = SwiftSetting.unsafeFlags([
"-Xfrontend", "-strict-concurrency=complete",
"-Xfrontend", "-warn-concurrency",
"-Xfrontend", "-enable-actor-data-race-checks"])

oscbyspro added a commit that referenced this issue Apr 7, 2023
@oscbyspro
Copy link
Owner Author

oscbyspro commented Apr 7, 2023

I added the constraint to ANKBinaryInteger to keep the noise down. I may reconsider it in the future, but I doubt it will be necessary. I also added Sendable conformances to: ANKError, ANKSign and ANKSigned.

@oscbyspro
Copy link
Owner Author

oscbyspro commented Apr 27, 2023

Hm. ANKBinaryInteger.Words and ANKBitPatternConvertible.BitPattern should be Sendable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition oh, so shiny!
Projects
None yet
Development

No branches or pull requests

1 participant