Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy division overflow detection #84

Closed
oscbyspro opened this issue Apr 20, 2023 · 1 comment
Closed

Lazy division overflow detection #84

oscbyspro opened this issue Apr 20, 2023 · 1 comment
Labels
brrr such code, much wow
Milestone
v1.2.0

Comments

@oscbyspro
Copy link
Owner

oscbyspro commented Apr 20, 2023 •
edited
Loading

There's some double counting going on in the division "reporting overflow" methods. Instead of predicting the overflow prior to performing the operation, it's probably better to report it as it occurs.
@oscbyspro oscbyspro added the brrr such code, much wow label Apr 20, 2023
@oscbyspro
Copy link
Owner Author

oscbyspro commented Apr 20, 2023 •
edited
Loading

This may require an internal "quotientAndRemainderReportingOverflow" method, and if that's the case then I will consider adding it as a protocol requirement.

@oscbyspro oscbyspro added this to the v1.2.0 milestone Apr 20, 2023
This was referenced Apr 21, 2023
Closed
Closed
oscbyspro added a commit that referenced this issue Apr 21, 2023
@oscbyspro
quotientAndRemainderReportingOverflow(dividingBy:) (#84) (#87) (#88)
e6c9130
@oscbyspro oscbyspro reopened this Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
brrr such code, much wow
Projects
None yet
Milestone
v1.2.0
Development

No branches or pull requests
1 participant
@oscbyspro