Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ktlint to 1.0.1 #1095

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Upgrade ktlint to 1.0.1 #1095

merged 2 commits into from
Nov 1, 2023

Conversation

Bambooin
Copy link
Collaborator

  • chore: upgrade ktlint to 1.0.1
  • chore: format code with ktlint 1.0.1

Pull request

Issue tracker

Fixes will automatically close the related issues

Fixes #

Feature

Describe features of pull request
Upgrade ktlint to 1.0.1 and format code, fix with some rule manually.

Code of conduct

Style lint

  • make sytle-lint

Build pass

  • make debug

Manually test

  • Done

Code Review

  1. No wildcards import
  2. Manual build and test pass
  3. GitHub action ci pass
  4. At least one contributor reviews and votes
  5. Can be merged clean without conflicts
  6. PR will be merged by rebase upstream base

Daily build

Login and download artifact at https://github.com/osfans/trime/actions

Additional Info

@Bambooin Bambooin merged commit e236272 into osfans:develop Nov 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant