Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix 20241207 #1525

Merged
merged 5 commits into from
Dec 9, 2024
Merged

Conversation

WhiredPlanck
Copy link
Collaborator

@WhiredPlanck WhiredPlanck commented Dec 6, 2024

Pull request

Issue tracker

Fixes will automatically close the related issues

Fixes #1518
Fixes #1516

Feature

Describe features of this pull request

Code of conduct

Code style

Build pass

  • make debug

Manually test

  • Done

Code Review

  1. No wildcards import
  2. Manual build and test pass
  3. GitHub Action CI pass
  4. At least one contributor review and approve
  5. Merged clean without conflicts
  6. PR will be merged by rebase upstream base

Daily build

Login and download artifact at https://github.com/osfans/trime/actions

Additional Info

@WhiredPlanck WhiredPlanck marked this pull request as draft December 7, 2024 11:03
@WhiredPlanck WhiredPlanck marked this pull request as ready for review December 7, 2024 15:13
@WhiredPlanck
Copy link
Collaborator Author

@goofyz @Bambooin All done.

@goofyz
Copy link
Collaborator

goofyz commented Dec 8, 2024

#1524 still is not fixed

@WhiredPlanck
Copy link
Collaborator Author

#1524 still is not fixed

Hm, some users in QQ group tell me it's OK ……

@WhiredPlanck
Copy link
Collaborator Author

#1524 still is not fixed

I remove the link to #1524 , let me pull another request to figure it out.

@WhiredPlanck WhiredPlanck merged commit ee0a85b into osfans:develop Dec 9, 2024
3 checks passed
@WhiredPlanck WhiredPlanck deleted the bug-fix-20241207 branch December 9, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants