[ServiceExtension] Better sanity checking and wildcard support #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjhargrave
requested changes
Mar 28, 2022
org.osgi.test.junit5/src/main/java/org/osgi/test/junit5/service/ServiceExtension.java
Outdated
Show resolved
Hide resolved
Fixes osgi#495 Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
kriegfrj
force-pushed
the
serviceextension-assignment-compatibility
branch
from
1fb6f07
to
2ebe832
Compare
bjhargrave
requested changes
Mar 29, 2022
org.osgi.test.junit5/src/main/java/org/osgi/test/junit5/service/ServiceExtension.java
Outdated
Show resolved
Hide resolved
This was
linked to
issues
Mar 29, 2022
Fixes osgi#494. Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>
kriegfrj
force-pushed
the
serviceextension-assignment-compatibility
branch
from
2ebe832
to
c66a797
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm expecting this build to fail with a versioning error.
The versioning error is easily fixed once a decision is made in respect to #496.