Mainly add the ability to create master ssh key if it doesn't exist

[mickaelperrin]

When provisioning inventories with master and slave, the slave roles fails if the master role hasn't been run on the master server because the ssh-key doesn't exist yet.

This PR introduces the (configurable) ability to create the missing ssh-key on the master if they don't exist.

It fixes also some deprecation warning and use YAML syntax everywhere.

[sebalix]

A carriage return is missing here

[sebalix]

I would prefer rsnapshot_slave_user_password: False as a default value

[sebalix]

when: rsnapshot_slave_user_password should be enough, as it is defined by default (even to False).
But this task is weird, SSH login on accounts with no password work very well with a SSH key, are you sure we need this? It depends on the SSH server configuration maybe?

[mickaelperrin]

While performing some tests, the rsnapshot_slave_user has been blocked.

I thought it was because it has no password and I use some os/sshd hardening roles.

But to be honest, I didn't find the task which may have done the block.

[mickaelperrin]

I just noticed that the rsnapshot_slave_user_password throws a really strange error:

The conditional check 'rsnapshot_slave_user_password' failed. The error was: error while evaluating conditional (rsnapshot_slave_user_password): 'password' is undefined

I don't understand why. I renamed the variable to rsnapshot_slave_userpassword and everything works...

I am missing something about Ansible I guess...

[sebalix]

Why removing the _? rsnapshot_slave_user_password was perfectly fine :) Your error was that there was no rsnapshot_slave_user_password variable defined in defaults/main.yml.

[sebalix]

Oups sorry, didn't see your comment...

[sebalix]

Strange, I don't know why... You can rename it with _passwd suffix, it works (already used that here: https://github.com/OCA/ansible-odoo/blob/master/defaults/main.yml#L7)

[mickaelperrin]

FYI, I deployed in production with no password and backup didn't work.

I found this error message in auth.log:

May 25 11:46:01 extranet sshd[8151]: User rbackup not allowed because account is locked

So I tried to define a password with rsnapshot_slave_user_passwd and get stuck with some strange errors. I don't understand why the pattern var: False in defaults then define the vars in inventory vars works for all other variables except for this one ??

If you have some idea, to help...

[12:17:31] sebalix.rsnapshot-slave : debug |  SUCCESS | 533ms
{
  - rsnapshot_slave_user_passwd: motdepasse
}
[12:17:31] sebalix.rsnapshot-slave : debug |  SUCCESS | 531ms
{
  - rsnapshot_slave_user_passwd|bool: False
}
[12:17:31] sebalix.rsnapshot-slave : Set password for backup user if provided | FAILED | 251ms
{
  - msg: The conditional check 'rsnapshot_slave_user_passwd' failed. The error was: error while evaluating conditional (rsnapshot_slave_user_passwd): 'motdepasse' is undefined

         The error appears to have been in '/Ansible/sebalix.rsnapshot-slave/tasks/config.yml': line 17, column 3, but may
         be elsewhere in the file depending on the exact syntax problem.

         The offending line appears to be:


         - name: Set password for backup user if provided
           ^ here
}

and even more strange

[12:27:48] sebalix.rsnapshot-slave : debug |  SUCCESS | 533ms
{
  - rsnapshot_slave_user_passwd: MonMotDePasseSecurisé
}
[12:27:48] sebalix.rsnapshot-slave : debug | SUCCESS | 538ms
{
  - rsnapshot_slave_user_passwd|bool: False
}
[12:27:49] sebalix.rsnapshot-slave : Set password for backup user if provided | FAILED | 228ms
{
  - msg: The conditional check 'rsnapshot_slave_user_passwd' failed. The error was: template error while templating string: unexpected char u'\xe9' at 26. String: {% if MonMotDePasseSecurisé %} True {% else %} False {% endif %}

         The error appears to have been in '/Ansible/sebalix.rsnapshot-slave/tasks/config.yml': line 17, column 3, but may
         be elsewhere in the file depending on the exact syntax problem.

         The offending line appears to be:


         - name: Set password for backup user if provided
           ^ here
}

[mickaelperrin]

Currently the only fix I see, is to set rsnapshot_slave_user_passwd: "" as default value and use when: rsnapshot_slave_user_passwd != "".

But I don't understand why it works for rsnapshot_master_host for example....

[sebalix]

Well, maybe False is not the best value... I think Ansible modules behave differently following the value (False, false, no, or empty), for instance I just saw that cron_file option from the cron Ansible module interprets False as string "False" (generating a /etc/cron.d/False crontab...).

Try this:

rsnapshot_slave_user_passwd:

without any value by default to see what happens.