Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preferences DataStore doesn't save data in v1.1.1 #38

Closed
osipxd opened this issue May 7, 2024 · 1 comment · Fixed by #41
Closed

Preferences DataStore doesn't save data in v1.1.1 #38

osipxd opened this issue May 7, 2024 · 1 comment · Fixed by #41
Assignees
@osipxd
Labels
bug Something isn't working

Comments

@osipxd
Copy link
Owner

osipxd commented May 7, 2024

Just observed that connected test for preferences DataStore fails.
DataStore doesn't write anything to disk.

Investigating the reason.
@osipxd osipxd added the bug Something isn't working label May 7, 2024
@osipxd osipxd self-assigned this May 7, 2024
@osipxd osipxd changed the title Preferences DataStore doesn't save data on v1.1.1 Preferences DataStore doesn't save data in v1.1.1 May 7, 2024
@osipxd
Copy link
Owner Author

osipxd commented May 7, 2024

Found the cause of the problem. I forgot to close IO streams in OkioToJvmSerializerAdapter 🤦

osipxd added a commit that referenced this issue May 7, 2024
@osipxd
fix: Close streams in OkioSerializer
a01c6f4 
Closes: #38
@osipxd osipxd mentioned this issue May 7, 2024
Merged
@osipxd osipxd closed this as completed in #41 May 7, 2024
osipxd added a commit that referenced this issue May 7, 2024
@osipxd
fix: Close streams in OkioSerializer
fb20467 
Closes: #38
@osipxd osipxd mentioned this issue May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@osipxd osipxd

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Preference DataStore saving osipxd/encrypted-datastore
1 participant
@osipxd