feat: app hash error channel #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czarcas7ic
commented
Jan 3, 2024
Comment on lines
+369
to
+377
| if strings.Contains(err.Error(), "wrong Block.Header.AppHash") { | ||
| bcR.BaseReactor.AppHashErrorChanBR <- p2p.AppHashError{ | ||
| Err: err, | ||
| Height: uint64(first.Height), | ||
| } | ||
| } else if strings.Contains(err.Error(), "wrong Block.Header.LastResultsHash") { | ||
| bcR.BaseReactor.AppHashErrorChanBR <- p2p.AppHashError{ | ||
| Err: err, | ||
| Height: uint64(first.Height - 1), |
There was a problem hiding this comment.
I used height-1 for lastResultHash and height for AppHash. I think this is correct, but highlighting that I would like this double checked
czarcas7ic
added a commit
that referenced
this pull request
Jan 6, 2024
feat: app hash error channel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an error channel which allows cometBFT to stream app hash errors to the sdk. With this information, the sdk can provide a more useful error message, specifically the hash of every module at the problematic block height.
The respective cosmos sdk PR: osmosis-labs/cosmos-sdk#500