Commits on Aug 19, 2024

1. perf(consensus): Run broadcast routines out of process (backport come… …

   …tbft#3180) (cometbft#3477)
   
   Run broadcast routines out of process. Right now each broadcast routine
   blocks the consensus mutex for roughly `num_peers *
   process_creation_time`, which is genuinely notable! This PR reduces the
   consensus blocking overhead to just be `process_creation_time`.
   
   On the latest osmosis branch with improvements, thats 20s of blocking
   time out of 140s (over the course of 1 hour. This 140s includes block
   execution!)
   
   ![image](https://github.com/cometbft/cometbft/assets/6440154/4c202988-a0d1-460e-89bc-7c1be11fd36f)
   
   Note that WAL write time should go significantly down with open PR's.
   For `HasVote`, this is a meaningful increase to consensus mutex lock
   time, so its worth reducing.
   
   ---
   
   #### PR checklist
   
   - [x] Tests written/updated - I can't think of any test to add
   - [x] Changelog entry added in `.changelog` (we use
   [unclog](https://github.com/informalsystems/unclog) to manage our
   changelog)
   - [x] Updated relevant documentation (`docs/` or `spec/`) and code
   comments - I don't know of any related docs here
   - [x] Title follows the [Conventional
   Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
   <hr>This is an automatic backport of pull request cometbft#3180 done by
   [Mergify](https://mergify.com).
   
   ---------
   
   Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
   Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>

   

   3 people committed Aug 19, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 1571532
   • Browse repository at this point

   Copy the full SHA

   1571532 View commit details

   Browse the repository at this point in the history

2. add back has vote message broadcast

   

   ValarDragon committed Aug 19, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for c98101d
   • Browse repository at this point

   Copy the full SHA

   c98101d View commit details

   Browse the repository at this point in the history