Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce dev rewards from totaly supply query #12

Merged
merged 6 commits into from
Jun 28, 2021
Merged

reduce dev rewards from totaly supply query #12

merged 6 commits into from
Jun 28, 2021

Conversation

antstalepresh
Copy link

Description

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

ValarDragon
ValarDragon approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM

ValarDragon
ValarDragon reviewed Jun 28, 2021
View reviewed changes
Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should rename DevRewardsAddr to DevUnvestedRewardsAddr, I'll do this locally

x/bank/keeper/querier.go Outdated Show resolved Hide resolved
x/bank/keeper/querier.go Outdated Show resolved Hide resolved
x/bank/keeper/querier.go Outdated Show resolved Hide resolved
x/bank/keeper/querier_test.go Outdated Show resolved Hide resolved
x/bank/keeper/querier_test.go Outdated Show resolved Hide resolved
@ValarDragon ValarDragon merged commit 261fe6a into v0.42.6-osmo-rebase Jun 28, 2021
ValarDragon added a commit that referenced this pull request Jul 9, 2021
@antstalepresh @ValarDragon
reduce dev rewards from totaly supply query (#12)
21a6262 
* reduce dev rewards from totaly supply query

* Rename devRewardsAddr -> devUnvestedRewardsAddr for clarity

* Fix build

* Fix more build errors

* Fix (hopefully last) build error

* Build error plz be fixed

Co-authored-by: ValarDragon <dojha12@gmail.com>
@ValarDragon ValarDragon deleted the v0.42.6-reduce-dev-rewards-from-total-supply-query branch July 9, 2021 20:28
@coderabbitai coderabbitai bot mentioned this pull request Jun 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValarDragon ValarDragon ValarDragon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antstalepresh @ValarDragon