V0.42.9 with cache kv improvement #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 28, 2021
|
Merging this in, as its producing correct state results and a 2x speedup on mainnet tested code. |
|
Not fully familiar with the context of the changes, but overall LGTM 👍 |
ValarDragon
added a commit
that referenced
this pull request
Aug 29, 2021
* use memdb for cachekv * Remove remaining n^2 nature of CacheKV (Speedup dirtyItems) * Delete deadcode, fix lint Co-authored-by: mconcat <monoidconcat@gmail.com>
Merged
19 tasks
faddat
pushed a commit
that referenced
this pull request
Jan 18, 2023
* use memdb for cachekv * Remove remaining n^2 nature of CacheKV (Speedup dirtyItems) * Delete deadcode, fix lint Co-authored-by: mconcat <monoidconcat@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix n^2 issues with the cacheKV store, and improve documentation in the process.
(Now if dirty items gets too big, just fix that. Additionally, don't use a doubly linked list as sorted data back-end, because that causes tons of n^2 overhead. Instead we use a proper B-tree for this. This is done with re-using of existing code)