Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bond duration #1010

Merged
merged 9 commits into from
Nov 18, 2022
Merged

Fix bond duration #1010

merged 9 commits into from
Nov 18, 2022

Conversation

jonator
Copy link
Member

@jonator jonator commented Nov 15, 2022 •
edited
Loading

Pool detail page

  • Show bonding durations for durations where bonded or unbonding share balances are > 0
  • Ensure 14 day card (as configured on chain) is the only card able to display superfluid info
  • Refresh data when a token completes unbond while app is open

Lock token modal

  • Ensure lock token modal only considers 14 day (on-chain param) is the superfluid durations (rather than just the highest gauge)

Minor

  • Fix token clipping issue

See bond card with custom duration
Screen Shot 2022-11-15 at 2 32 13 PM
It doesn't use the vial graphics, which indicate on-chain-param durations (1,7,14 days currently)

@vercel
Copy link

vercel bot commented Nov 15, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
osmosis-frontend ✅ Ready (Inspect) Visit Preview Nov 16, 2022 at 5:36PM (UTC)
osmosis-frontend-legacy ✅ Ready (Inspect) Visit Preview Nov 16, 2022 at 5:36PM (UTC)
osmosis-frontend-v13-chain ✅ Ready (Inspect) Visit Preview Nov 16, 2022 at 5:36PM (UTC)
osmosis-frontier ✅ Ready (Inspect) Visit Preview Nov 16, 2022 at 5:36PM (UTC)
osmosis-testnet ✅ Ready (Inspect) Visit Preview Nov 16, 2022 at 5:36PM (UTC)

@jonator jonator added the bug label Nov 15, 2022
@arispech
Copy link

Looks good to me!

@jonator
Copy link
Member Author

jonator commented Nov 16, 2022

@arispech please approve

arispech
arispech approved these changes Nov 16, 2022
View reviewed changes
Copy link

@arispech arispech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA passing, lgtm.

@jonator jonator merged commit 7da103a into stage Nov 18, 2022
@jonator jonator deleted the jonator/fix-bond-duration branch November 18, 2022 16:13
@jonator jonator mentioned this pull request Nov 30, 2022
Merged
JoseRFelix pushed a commit that referenced this pull request Dec 5, 2022
@jonator @JoseRFelix
Fix bond duration (#1010)
9122cd9 
* Ensure superfluid duration is chain config highest duration

* Fix superfluid bond card, and sorting bond cards

* Add clarifying comment

* Fix token clip issue

* Add space before bond button

* Fetch user shares when unbond occurs

* Remove log

* Remove unused code, remove token icon rounding/clipping

* Only show vial graphics if pool is internally incentivized
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arispech arispech arispech approved these changes

@daniel-farina daniel-farina daniel-farina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonator @arispech @daniel-farina