Update ECH IBC Channels #1018
Merged
Update ECH IBC Channels #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src: channel-403, dst: channel-11
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I would be in agreement with ECH(old) |
|
Just a note on this. Pool 848 is now up to 1513 OSMO at the time of writing. https://frontier.osmosis.zone/pool/848 |
Echelon (current)
JoseRFelix
pushed a commit
that referenced
this pull request
Dec 5, 2022
* Update ECH channels src: channel-403, dst: channel-11 * Re-add old demon * add echelon legacy * fix echelon legacy * update Echelon chain name Echelon (current) * Revert to only ECH new token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src: channel-403, dst: channel-11
New IBC denom hash can be confirmed by using their transfer website: https://app.ech.network/ibc
SHA256("transfer/channel-403/aechelon") = ibc/47EE...177D
This will make the old denom unofficial. Users' old ECH tokens would then be unlisted in the Assets page (should we change it to "ECH (old)"?
Currently looks like this:
Getting odd behaviour from the token search:
Edit: The complexity of this seemingly simple change as blown up massively. It might be more easily possible if there were a way to change between channels (but still only seeing 1 version at a time). But at this point it is my recommendation to consider abandoning the idea of displaying 2 version at once, and simply ask users to view pools containing ECH to see, trade, and LP their old-channel ECH (it cannot be withdrawn anyway).
We could simply update the the latest channel, removing the old-channel token. The biggest downsides to this are no longer seeing it in the Asset page, and not finding in the Swap page.
Pool 747 (old-channel ECH/OSMO) would look like this (now with the channel name included):
While 848 (new-channel ECH/OSMO) would appear canonical, and is included in the Swap page trade router:
