Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Osmosis chain configuration overwrite #824

Merged
merged 21 commits into from
Nov 9, 2022

Conversation

daniel-farina
Copy link
Contributor

This PR will close #809.

  • Allows overwriting Osmosis chain config with custom parameters set on a .env configuration file. They are only overwriten when present.

@vercel
Copy link

vercel bot commented Sep 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
osmosis-frontend ✅ Ready (Inspect) Visit Preview Nov 9, 2022 at 6:51PM (UTC)
osmosis-frontend-v13-chain ✅ Ready (Inspect) Visit Preview Nov 9, 2022 at 6:51PM (UTC)
osmosis-frontier ✅ Ready (Inspect) Visit Preview Nov 9, 2022 at 6:51PM (UTC)
osmosis-testnet ✅ Ready (Inspect) Visit Preview Nov 9, 2022 at 6:51PM (UTC)

@niccoloraspa
Copy link
Member

Are the environment variables used at build time or runtime?

@daniel-farina
Copy link
Contributor Author

Are the environment variables used at build time or runtime?

I believe at build time but maybe @jonator can confirm. On dev, they don't get applied unless I stop and start the dev server.

@daniel-farina daniel-farina marked this pull request as ready for review September 23, 2022 07:19
packages/web/.env Show resolved Hide resolved
packages/web/config/chain-infos.ts Outdated Show resolved Hide resolved
packages/web/config/chain-infos.ts Outdated Show resolved Hide resolved
packages/web/config/chain-infos.ts Outdated Show resolved Hide resolved
@daniel-farina
Copy link
Contributor Author

This is ready ser @jonator @niccoloraspa
Ready to test on stage.

@jonator
Copy link
Member

jonator commented Nov 5, 2022

Please resolve conflicts @daniel-farina

@daniel-farina
Copy link
Contributor Author

Please resolve conflicts @daniel-farina

Conflicts fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose configuration as environment variables
4 participants