Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CL Migrations] Remove log bombs #4540

Closed
mattverse opened this issue Mar 9, 2023 · 0 comments · Fixed by osmosis-labs/cosmos-sdk#432
Closed

[CL Migrations] Remove log bombs #4540

mattverse opened this issue Mar 9, 2023 · 0 comments · Fixed by osmosis-labs/cosmos-sdk#432
Assignees
@mattverse
Labels
C:x/concentrated-liquidity C:x/gamm Changes, features and bugs related to the gamm module. F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board

Comments

@mattverse
Copy link
Member

Background

The process of migrations results in huge log bombs, specifically because migration includes the process of Exit Pools, which contains logs from burning tokens from the module account in the process. Migrations can cause huge logs to a node, which could look something like this:
image

Suggested Design

The log bomb is probably stemming from
https://github.com/osmosis-labs/osmosis/blob/83968d9ccd/x/gamm/keeper/share.go#L74-L90

Removing these log bombs can include edits from the sdk side, more investigation needed for this

Acceptance Criteria

  • Log bombs for burning tokens from module account has been removed
@mattverse mattverse added C:x/gamm Changes, features and bugs related to the gamm module. C:x/concentrated-liquidity F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board labels Mar 9, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development Mar 9, 2023
@mattverse mattverse self-assigned this Mar 13, 2023
@p0mvn p0mvn moved this from Needs Triage 🔍 to Todo 🕒 in Osmosis Chain Development Mar 26, 2023
@p0mvn p0mvn moved this from Todo 🕒 to Needs Triage 🔍 in Osmosis Chain Development Apr 10, 2023
@mattverse mattverse mentioned this issue Apr 14, 2023
Merged
@p0mvn p0mvn moved this from Needs Triage 🔍 to Todo 🕒 in Osmosis Chain Development Apr 17, 2023
@czarcas7ic czarcas7ic moved this from Todo 🕒 to Needs PR Review in Osmosis Chain Development Apr 27, 2023
@github-project-automation github-project-automation bot moved this from Needs PR Review to Done ✅ in Osmosis Chain Development Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattverse mattverse

Labels
C:x/concentrated-liquidity C:x/gamm Changes, features and bugs related to the gamm module. F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Remove burn logs from Bank module osmosis-labs/cosmos-sdk
1 participant
@mattverse