chore: Remove burn logs from Bank module #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any desire to keep this as a log but for debug mode only? |
|
@czarcas7ic yes definitely! Nice suggestion, changed! |
mattverse
changed the title
mergify bot
pushed a commit
that referenced
this pull request
Apr 27, 2023
* Remove burn logs * Change to debug log (cherry picked from commit 6ae3ebb)
mattverse
added a commit
that referenced
this pull request
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: osmosis-labs/osmosis#4540
What is the purpose of the change
Removes Burn Logs from Bank module.
We have alot of incidences where we Burn coins, for example, whenever user exits a pool, it would burn the pool shares, triggering this log layer.
We also have future incidences where we will have multiples of simultaneous burns, e,g when we are migrating shares from one pool to other. This would cause log bombs in nodes as shown in the original issue.
This PR removes log bombs caused from burns.
Brief Changelog
Testing and Verifying
This change does not need tests
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? (yes / no)x/<module>/spec/) / Osmosis docs repo / not documented)