-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: taker fee share #8310
Merged
Merged
feat: taker fee share #8310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:CLI
C:x/incentives
C:x/superfluid
C:x/txfees
C:app-wiring
Changes to the app folder
C:x/twap
Changes to the twap module
C:x/poolmanager
labels
May 24, 2024
github-actions
bot
added
C:docs
Improvements or additions to documentation
C:x/lockup
C:x/gamm
Changes, features and bugs related to the gamm module.
T:CI
C:x/mint
C:x/epochs
C:x/pool-incentives
T:build
C:x/tokenfactory
C:simulator
Edits simulator or simulations
C:x/concentrated-liquidity
labels
May 24, 2024
czarcas7ic
commented
May 24, 2024
@@ -358,7 +358,7 @@ func (q Querier) EstimateTradeBasedOnPriceImpact( | |||
|
|||
poolI, poolErr := swapModule.GetPool(ctx, req.PoolId) | |||
if poolErr != nil { | |||
return nil, status.Error(codes.Internal, err.Error()) | |||
return nil, status.Error(codes.Internal, poolErr.Error()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drive by
p0mvn
reviewed
Jul 25, 2024
Co-authored-by: Roman <roman@osmosis.team>
… skimmed from poolmanager
p0mvn
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work
This was referenced Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C:app-wiring
Changes to the app folder
C:CLI
C:docs
Improvements or additions to documentation
C:simulator
Edits simulator or simulations
C:x/concentrated-liquidity
C:x/epochs
C:x/gamm
Changes, features and bugs related to the gamm module.
C:x/incentives
C:x/lockup
C:x/mint
C:x/pool-incentives
C:x/poolmanager
C:x/superfluid
C:x/tokenfactory
C:x/twap
Changes to the twap module
C:x/txfees
T:build
T:CI
V:state/breaking
State machine breaking PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #8227
What is the purpose of the change
This PR implements the taker fee share logic that will be used to skim taker fee shares generated by swap routes that contain denoms that have a taker fee share agreement with the Osmosis protocol.
To review this PR, I recommend the following order:
Testing and Verifying
Setting a Taker Fee Share Agreement
To set a taker fee share agreement for a denom, use the new gov v1 type, sending a message of type
MsgSetTakerFeeShareAgreementForDenom
, with [denom] [skim_percent] [skim_address] as inputs. This message can only be executed by the gov module account.Querying Taker Fee Share Agreements
To query all taker fee share agreements:
To query the taker fee share agreement for a specific denom:
Querying Accrued Value and Accumulators
To query all taker fee share accumulators:
To query the accrued value of taker fees for specific denoms:
Registering an Alloyed Pool
To register an alloyed pool for taker fee revenue sharing, use the new gov v1 type, sending a message of type
MsgSetRegisteredAlloyedPool
, with [pool_id] as the input. This message can only be executed by the gov module account.Querying an Alloyed Pool
To query all registered alloyed pools:
To query the registered alloyed pool state from a specific denom: