chore: set optimistic execution #8393

czarcas7ic · 2024-06-15T23:10:12Z

Closes: #XXX

What is the purpose of the change

coderabbitai · 2024-06-16T02:01:49Z

Walkthrough

The latest update introduces several significant enhancements to the osmosis platform, including support for superfluid staking of non-pool assets, unidirectional trading pair fee overrides, and fixing fee charging issues. Additionally, upgrades to the SDK v50 and Comet v0.38 have been incorporated, along with a new governance parameter for setting the minimum deposit ratio. Optimistic execution has also been enabled to improve transaction processing efficiency.

Changes

File/Path	Change Summary
CMD changes	Added `SetOptimisticExecution()` method to `baseapp` in `newApp` function
`osmosis` core	Introduced support for non-pool assets in superfluid staking, uni-directional trading pair taker fee overrides, and enabled optimistic execution
SDK and Comet Integration	Upgraded to SDK v50 and Comet v0.38
Governance Parameters	Set `MinDepositRatio` governance parameter to 1% for SDK v50 upgrade
Fee Charging Fix	Addressed fee payer charge on every message in the `smartaccount` module

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant OsmosisApp
    participant Governance
    participant TradingModule
    participant BaseApp

    User->>+OsmosisApp: Initiate Superfluid Staking
    OsmosisApp->>TradingModule: Validate Non-Pool Asset
    TradingModule-->>OsmosisApp: Non-Pool Asset Validated

    User->>+OsmosisApp: Initiate Trade
    OsmosisApp->>TradingModule: Check Taker Fee Override
    TradingModule-->>OsmosisApp: Taker Fee Applied

    User->>+OsmosisApp: Submit Governance Proposal
    OsmosisApp->>Governance: Set MinDepositRatio to 1%
    Governance-->>OsmosisApp: MinDepositRatio Set

    User->>+OsmosisApp: Execute Transaction
    OsmosisApp->>BaseApp: Execute with Optimism
    BaseApp-->>OsmosisApp: Optimistic Execution Completed

Poem

In the world of Osmosis, great changes take flight,
With assets non-pool staking in superfluid delight,
Fees adjusted, trading pairs made fair,
SDK and Comet upgrades, a future to share.
Optimistic execution speeds our quest,
In governance, deposit ratios set to the best.
Oh, the marvels of code, in the blockchain's nest! 🌌🐇

Tip

Early access features: enabled

We are currently testing the following features in early access:

- **Anthropic `claude-3-5-sonnet` model for code reviews and chat**: This new model is designed to enhance code understanding and generation capabilities. We're excited to hear your feedback as we evaluate its performance.

  Note:
- You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
- Please join our [Discord Community](https://discord.com/invite/GsXnASn26c) to provide feedback and report issues.
- OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

ValarDragon · 2024-06-19T16:35:13Z

Actually since this is state compat, maybe we should get v26.0.0 without this, and v26.1.0 with it?

czarcas7ic · 2024-06-19T19:32:12Z

@ValarDragon I was told by Facu from Binary Builders that the feat does nothing without 2/3 voting power on it.

We can add in minor but I don't think there is a high likelyhood of getting voting power on it without a manual push

(msg here https://osmosis-network.slack.com/archives/C047X1T6ERK/p1718615619678329?thread_ts=1718492283.495959&cid=C047X1T6ERK)

PaddyMc

⚡

czarcas7ic · 2024-06-25T21:46:31Z

Lets keep this open until v26.0.0 is out and then merge, as per Dev's request.

github-actions · 2024-07-04T00:02:29Z