Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump cometbft #8831

Merged
merged 2 commits into from
Nov 18, 2024
Merged

chore: bump cometbft #8831

merged 2 commits into from
Nov 18, 2024
+17 −14

Conversation

crnbarr93
Copy link
Contributor

What is the purpose of the change

Bump cometbft => v0.38.15-v27-osmo-2

@crnbarr93 crnbarr93 added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v27.x backport patches to v27.x branch labels Nov 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

Important Notice

This PR modifies an in-repo Go module. It is one of:

  • osmomath
  • osmoutils
  • x/ibc-hooks
  • x/epochs

The dependent Go modules, especially the root one, will have to be
updated to reflect the changes. Failing to do so might cause e2e to fail.

Please follow the instructions below:

  1. Open https://github.com/osmosis-labs/osmosis/actions/workflows/go-mod-auto-bump.yml
  2. Provide the current branch name
  3. On success, confirm if an automated commit corretly updated the go.mod and go.sum files

Please let us know if you need any help.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 18, 2024

Walkthrough

The pull request updates the CHANGELOG.md file by adding a new section for unreleased changes under "State Compatible." It includes an entry for a chore to bump the cometbft version, linked to pull request #8831. The existing version entries have been reorganized to list the latest version (v27.0.0) first, followed by previous versions in descending order, with categorized changes detailed for each version.

Changes

File Change Summary
CHANGELOG.md - Added a new section for unreleased changes: ### State Compatible
- Added entry: * [#8831](https://github.com/osmosis-labs/osmosis/pull/8831) chore: bump cometbft under ### State Compatible
- Updated version section for ## v27.0.0
- Reorganized version sections to display the latest version first

Possibly related PRs

Suggested reviewers

  • mattverse
  • nicolaslara
  • PaddyMc
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 46b1cb8 and 74b3221.

⛔ Files ignored due to path filters (5)
  • go.mod is excluded by !**/*.mod
  • go.sum is excluded by !**/*.sum, !**/*.sum
  • osmoutils/go.mod is excluded by !**/*.mod
  • x/epochs/go.mod is excluded by !**/*.mod
  • x/ibc-hooks/go.mod is excluded by !**/*.mod
📒 Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
🔇 Additional comments (3)
CHANGELOG.md (3)

45-46: LGTM: Unreleased changes follow changelog format

The unreleased changes section properly documents a state compatible change for bumping cometbft version.

Line range hint 1-44: LGTM: Well-documented changelog guidelines

The header section provides comprehensive guidance for maintaining the changelog, following Keep a Changelog conventions and clearly defining:

  • Principles for human-readable changelogs
  • Instructions for adding entries
  • Standardized categories for changes
  • Link formatting rules

Line range hint 48-5824: LGTM: Version entries follow consistent format

The version history entries maintain good consistency with:

  • Clear version headers and dates
  • Proper categorization of changes
  • Consistent PR link formatting
  • Clear marking of breaking changes

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@crnbarr93 crnbarr93 merged commit 2018928 into main Nov 18, 2024
21 checks passed
@crnbarr93 crnbarr93 deleted the chore/cometbft-bump branch November 18, 2024 14:46
mergify bot pushed a commit that referenced this pull request Nov 18, 2024
@crnbarr93 @mergify
chore: bump cometbft (#8831)
0a78f81 
* chore: bump cometbft

* chore: changelog

(cherry picked from commit 2018928)
@mergify mergify bot mentioned this pull request Nov 18, 2024
Merged
crnbarr93 added a commit that referenced this pull request Nov 18, 2024
@mergify @crnbarr93
chore: bump cometbft (#8831) (#8832)
100ba81 
* chore: bump cometbft

* chore: changelog

(cherry picked from commit 2018928)

Co-authored-by: Connor Barr <crnbarr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaddyMc PaddyMc PaddyMc approved these changes

@mattverse mattverse Awaiting requested review from mattverse mattverse is a code owner

@nicolaslara nicolaslara Awaiting requested review from nicolaslara nicolaslara is a code owner

Assignees
No one assigned
Labels
A:backport/v27.x backport patches to v27.x branch C:x/epochs V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crnbarr93 @PaddyMc